From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MO5YH-0004z3-IS
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 03:57:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MO5YE-0004wx-0q
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 03:57:21 -0400
Received: from [199.232.76.173] (port=40095 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MO5YD-0004wp-NT
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 03:57:17 -0400
Received: from mx2.redhat.com ([66.187.237.31]:55759)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MO5YC-0005QI-Ne
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 03:57:17 -0400
Message-ID: <4A52FF8D.1020200@redhat.com>
Date: Tue, 07 Jul 2009 09:55:57 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] RFC: Add new block driver for the VDI format
References: <4A4E5AFC.4020206@mail.berlios.de> <4A51FE07.2040307@codemonkey.ws>
	<4A52682D.7000602@mail.berlios.de>
In-Reply-To: <4A52682D.7000602@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Stefan Weil schrieb:
> It would help if you could already commit the synchronous version
> as soon as the endianess issue (detected by Kevin Wolf, thanks)
> and an additional bug in the write code are fixed
> (code is ready, but still untested - a patch will follow this week).

Maybe somebody should run qemu-iotests for it on a big endian machine to
make sure it works. Unfortunately, I don't have one here.

For the write bug you might want to write a new qemu-iotests test case
as it doesn't seem to be covered yet (at least, Christoph said the
driver passes).

> I don't plan to change the code's license from GPL to MIT.
> This is a matter of my personal taste. Is this a problem
> for new block driver code?

I guess it's okay. It's just that until now the whole block code was
under a single license which I would have liked to retain. But again
just a matter of personal taste.

Kevin