From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MO80E-000514-D8 for qemu-devel@nongnu.org; Tue, 07 Jul 2009 06:34:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MO809-0004zH-8B for qemu-devel@nongnu.org; Tue, 07 Jul 2009 06:34:21 -0400 Received: from [199.232.76.173] (port=46451 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MO809-0004zE-3I for qemu-devel@nongnu.org; Tue, 07 Jul 2009 06:34:17 -0400 Received: from mx2.redhat.com ([66.187.237.31]:52657) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MO808-0007h6-JI for qemu-devel@nongnu.org; Tue, 07 Jul 2009 06:34:16 -0400 Message-ID: <4A53245D.30202@redhat.com> Date: Tue, 07 Jul 2009 12:33:01 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] RFC: Add new block driver for the VDI format References: <4A4E5AFC.4020206@mail.berlios.de> <4A51FE07.2040307@codemonkey.ws> <4A52682D.7000602@mail.berlios.de> <4A52FF8D.1020200@redhat.com> <20090707103046.GB23964@lst.de> In-Reply-To: <20090707103046.GB23964@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: QEMU Developers Christoph Hellwig schrieb: > On Tue, Jul 07, 2009 at 09:55:57AM +0200, Kevin Wolf wrote: >> For the write bug you might want to write a new qemu-iotests test case >> as it doesn't seem to be covered yet (at least, Christoph said the >> driver passes). > > Yes, the test suite passes. But currrently the coverage for non-qcow2 > image formats is a bit limited as we skip all tests that require an > image check. I plan to change that soon and run all tests for all image > formats - a lacking qemu-img check command will simply cause the check > to always succeed. Oh, I see. What you suggest for the checks makes sense to me. Kevin