From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MODgw-0006Y8-3x for qemu-devel@nongnu.org; Tue, 07 Jul 2009 12:38:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MODgq-0006X3-Td for qemu-devel@nongnu.org; Tue, 07 Jul 2009 12:38:49 -0400 Received: from [199.232.76.173] (port=40989 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MODgq-0006Wy-PL for qemu-devel@nongnu.org; Tue, 07 Jul 2009 12:38:44 -0400 Received: from mx2.redhat.com ([66.187.237.31]:46559) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MODgq-0001N9-8R for qemu-devel@nongnu.org; Tue, 07 Jul 2009 12:38:44 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n67GchOv023967 for ; Tue, 7 Jul 2009 12:38:43 -0400 Message-ID: <4A537AA4.8000101@redhat.com> Date: Tue, 07 Jul 2009 19:41:08 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qcow2: Fix L1 table memory allocation References: <1246982982-11615-1-git-send-email-kwolf@redhat.com> <4A537735.9060904@redhat.com> <4A5378BB.9070601@redhat.com> In-Reply-To: <4A5378BB.9070601@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 07/07/2009 07:32 PM, Kevin Wolf wrote: >> Unrelated note: using qemu_memalign() here would reduce the copying for >> cache=none. >> > > Good point. I guess there are more places where we could use > qemu_memalign, so I would prefer to change them all in another patch. > > Definitely. -- error compiling committee.c: too many arguments to function