From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOPMF-0004LW-4C
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 01:06:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOPM8-0004H4-19
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 01:06:13 -0400
Received: from [199.232.76.173] (port=47582 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOPM7-0004Gl-9Q
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 01:06:07 -0400
Received: from mx2.redhat.com ([66.187.237.31]:59618)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MOPM6-00057X-Kp
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 01:06:06 -0400
Message-ID: <4A54294C.1030409@redhat.com>
Date: Wed, 08 Jul 2009 08:06:20 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot
References: <20090707192631.GQ11590@us.ibm.com>
In-Reply-To: <20090707192631.GQ11590@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 07/07/2009 10:26 PM, Ryan Harper wrote:
> Add a new monitor command (system_reboot) for a soft reboot which uses
> system_powerdown to trigger ACPI shutdown in the guest and once shutdown
> is complete, trigger a reset instead of exiting qemu.
>
> Depends on commit a6d6552426dcbf726e5549f08b70c9318d6be14b which enabled
> ACPI power button support.
>
> V2:
>      -added reset handler to lower the reboot flag on reset.
>
> Tested with:
>      - Ubuntu 9.04 64-bit guest.
>      - SLES 10 SP2 32-bit guest.
>      - RHEL 5.3 32 and 64 bit guests.
>
>    

I think a combination of system_powerdown, avoiding exit on shutdown, 
and system_reset is more flexible as it allows the controller to modify 
the guest before rebooting it.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.