From: Paolo Bonzini <bonzini@gnu.org>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 09/17] pc.c: remove a global variable, RTCState *rtc_state.
Date: Wed, 08 Jul 2009 09:44:31 +0200 [thread overview]
Message-ID: <4A544E5F.2050700@gnu.org> (raw)
In-Reply-To: <1246605098-24411-10-git-send-email-yamahata@valinux.co.jp>
On 07/03/2009 09:11 AM, Isaku Yamahata wrote:
> +#if defined(TARGET_I386)
> /* set CMOS shutdown status register (index 0xF) as S3_resume(0xFE)
> BIOS will read it and start S3 resume at POST Entry */
> +static RTCState *rtc_state;
> +void cmos_set_s3_resume_init(RTCState *s)
> +{
> + rtc_state = s;
> +}
> +
> void cmos_set_s3_resume(void)
> {
> if (rtc_state)
> rtc_set_memory(rtc_state, 0xF, 0xFE);
> }
> +#endif
Comment above the wrong function. Also, rather than defining it only
for TARGET_I386, I would #ifdef just the body if cmos_set_s3_resume for
cleanliness.
Paolo
next prev parent reply other threads:[~2009-07-08 7:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 7:11 [Qemu-devel] [PATCH 00/17] split out piix specific part from pc emulator. v2 Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 01/17] acpi.c: split out pc smbus routines from acpi.c into pc_smbus.c Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 02/17] acpi.c: split out apm register emulation Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 03/17] acpi.c: make qemu_system_powerdown() piix independent Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 04/17] acpi: add acpi constants from linux header files and use them Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 05/17] acpi.c: split acpi.c into the common part and the piix4 part Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 06/17] pc.c: Make smm enable/disable function i440fx independent Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 07/17] pc.c: remove unnecessary global variables, pit and ioapic Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 08/17] pc.c: remove a global variable, floppy_controller Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 09/17] pc.c: remove a global variable, RTCState *rtc_state Isaku Yamahata
2009-07-08 7:44 ` Paolo Bonzini [this message]
2009-07-08 15:28 ` [Qemu-devel] " Isaku Yamahata
2009-07-08 15:30 ` Paolo Bonzini
2009-07-09 3:17 ` Isaku Yamahata
2009-07-09 7:14 ` Paolo Bonzini
2009-07-03 7:11 ` [Qemu-devel] [PATCH 10/17] pc.c: introduce a function to allocate cpu irq Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 11/17] pc.c: make pc_init1() not refer ferr_irq directly Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 12/17] pc.c: split out cpu initialization from pc_init1() into pc_cpus_init() Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 13/17] pc.c: split out memory allocation from pc_init1() into pc_memory_init() Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 14/17] pc.c: split out vga initialization from pc_init1() into pc_vga_init() Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 15/17] pc.c: split out basic device init from pc_init1() into pc_basic_device_init() Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 16/17] pc.c: split out pci device init from pc_init1() into pc_pci_device_init() Isaku Yamahata
2009-07-03 7:11 ` [Qemu-devel] [PATCH 17/17] pc.c: split out piix specific part from pc.c into pc_piix.c Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A544E5F.2050700@gnu.org \
--to=bonzini@gnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).