From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOWlS-0004VQ-G2
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:00:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOWlJ-0004Ue-SX
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:00:43 -0400
Received: from [199.232.76.173] (port=34063 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOWlI-0004UQ-3Q
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:00:36 -0400
Received: from mx2.redhat.com ([66.187.237.31]:49961)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MOWlH-0003Li-Fu
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:00:35 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n68D0YFj023937
	for <qemu-devel@nongnu.org>; Wed, 8 Jul 2009 09:00:34 -0400
Message-ID: <4A54986D.301@redhat.com>
Date: Wed, 08 Jul 2009 15:00:29 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3 v2] Add a pc-0-10 machine type for
	compatibility with 0.10.x
References: <1244821292.30522.56.camel@blaa>	<4A327E4A.7010300@codemonkey.ws>	<1244825303.26769.19.camel@blaa>	<20090614095016.GA7560@redhat.com>	<1245056916.6891.31.camel@blaa>	<4A3613EC.6030608@redhat.com>	<20090615103249.GB6351@redhat.com>	<4A363012.8050409@redhat.com>	<20090615114858.GG6351@redhat.com>	<4A3636FA.1040609@redhat.com>	<20090615124101.GH6351@redhat.com>	<4A364381.401@redhat.com>	<4A364401.6010500@codemonkey.ws>	<4A3647FB.9010808@redhat.com>	<4A364B53.9080007@codemonkey.ws>	<4A364FE0.40204@redhat.com>
	<4A3651EB.3070204@codemonkey.ws>	<4A36555A.4090303@redhat.com>
	<4A3659A0.3050108@codemonkey.ws>	<4A366348.1030202@redhat.com>
	<1245083229.3222.103.camel@blaa>	<4A368F12.2090504@codemonkey.ws>
	<1246964898.2836.38.camel@blaa>	<1246964950.2836.39.camel@blaa>
	<1246964998.2836.40.camel@blaa>	<1246965054.2836.41.camel@blaa>
	<4A5338FC.9030301@redhat.com>	<1247049984.3270.52.camel@blaa>
	<1247050083.3270.54.camel@blaa>
In-Reply-To: <1247050083.3270.54.camel@blaa>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On 07/08/09 12:48, Mark McLoughlin wrote:
> Add a pc-0-10 machine type to allow a pc machine to be created with
> virtio block and console devices compatibility with qemu-0.10.x.

> +enum {
> +    COMPAT_DEFAULT = 0,
> +    COMPAT_0_10, /* compatible with qemu 0.10.x */
> +};

Hmm.  Just digged in the virtio blk code.  Noticed some ppc machines 
have virtio block devices too.  So linking it to a machine type looks 
wrong to me.

Maybe better add a global '-compat' switch and a global compat enum 
where every driver can just look at?

Another question:  Is migrating from 0.11 in 0.10-compat mode to 0.10 
supposed to work?  If so we make virtio-net better turn off msi then.

cheers,
   Gerd