From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOWqD-000719-Sq for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:05:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOWq7-0006pw-Ev for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:05:40 -0400 Received: from [199.232.76.173] (port=43945 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOWq7-0006p9-4X for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:05:35 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:37862) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MOWq6-00045b-K9 for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:05:34 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n68D0Hqi000655 for ; Wed, 8 Jul 2009 09:00:17 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n68D5MqE249860 for ; Wed, 8 Jul 2009 09:05:22 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n68D5MKT002367 for ; Wed, 8 Jul 2009 09:05:22 -0400 Message-ID: <4A549990.2060205@us.ibm.com> Date: Wed, 08 Jul 2009 08:05:20 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot References: <20090707192631.GQ11590@us.ibm.com> <20090708075601.GJ28046@redhat.com> In-Reply-To: <20090708075601.GJ28046@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Ryan Harper , qemu-devel@nongnu.org Gleb Natapov wrote: > On Tue, Jul 07, 2009 at 02:26:31PM -0500, Ryan Harper wrote: > >> Add a new monitor command (system_reboot) for a soft reboot which uses >> system_powerdown to trigger ACPI shutdown in the guest and once shutdown >> is complete, trigger a reset instead of exiting qemu. >> >> Depends on commit a6d6552426dcbf726e5549f08b70c9318d6be14b which enabled >> ACPI power button support. >> >> V2: >> -added reset handler to lower the reboot flag on reset. >> > OS is free to ignore ACPI shutdown request and in this case > reboot_requested will not be reset. On the next user initiated > guest power down qemu will reboot instead of exit. > Indeed. This is what has kept me from applying this but I just can't think of any better solution. Any ideas? The drive behind implementing this feature is so that we can implement a proper virDomainReboot in libvirt. -- Regards, Anthony Liguori