From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOWtq-0001iP-6z
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:09:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOWtj-0001cc-Ns
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:09:24 -0400
Received: from [199.232.76.173] (port=59505 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOWti-0001bl-QN
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:09:19 -0400
Received: from mx2.redhat.com ([66.187.237.31]:54388)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MOWti-0004fa-1n
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:09:18 -0400
Message-ID: <4A549B12.9020503@redhat.com>
Date: Wed, 08 Jul 2009 16:11:46 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot
References: <20090707192631.GQ11590@us.ibm.com> <4A54294C.1030409@redhat.com>
	<4A549A0F.5040902@codemonkey.ws>
In-Reply-To: <4A549A0F.5040902@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Ryan Harper <ryanh@us.ibm.com>, qemu-devel@nongnu.org

On 07/08/2009 04:07 PM, Anthony Liguori wrote:
> Avi Kivity wrote:
>> On 07/07/2009 10:26 PM, Ryan Harper wrote:
>>> Add a new monitor command (system_reboot) for a soft reboot which uses
>>> system_powerdown to trigger ACPI shutdown in the guest and once 
>>> shutdown
>>> is complete, trigger a reset instead of exiting qemu.
>>>
>>> Depends on commit a6d6552426dcbf726e5549f08b70c9318d6be14b which 
>>> enabled
>>> ACPI power button support.
>>>
>>> V2:
>>>      -added reset handler to lower the reboot flag on reset.
>>>
>>> Tested with:
>>>      - Ubuntu 9.04 64-bit guest.
>>>      - SLES 10 SP2 32-bit guest.
>>>      - RHEL 5.3 32 and 64 bit guests.
>>>
>>
>> I think a combination of system_powerdown, avoiding exit on shutdown, 
>> and system_reset is more flexible as it allows the controller to 
>> modify the guest before rebooting it.
>
> You need notification that the shutdown has occurred.  That's the only 
> bit we're missing today.  It's still not perfect though.
>
> libvirt does system_powerdown, guest completely ignores it, user 
> decides to power off, libvirt cannot tell the difference between user 
> requested power off and ACPI driven power down.

Does the patch handle this case?

-- 
error compiling committee.c: too many arguments to function