From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOXUi-0006qP-Lv for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:47:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOXUf-0006kT-2C for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:47:32 -0400 Received: from [199.232.76.173] (port=42254 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOXUe-0006kE-PE for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:47:28 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48026) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MOXUe-0003rR-8m for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:47:28 -0400 Message-ID: <4A54A327.9020501@redhat.com> Date: Wed, 08 Jul 2009 15:46:15 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] sanitize ->bdrv_get_buffer / ->bdrv_put_buffer calling conventions References: <20090707173401.GA5145@lst.de> In-Reply-To: <20090707173401.GA5145@lst.de> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Christoph Hellwig schrieb: > The VM state offset is an concept internal to the image format, it > doesn't even have to be a traditional linear offset. So change the > ->bdrv_get_buffer / ->bdrv_put_buffer calling convention to always pass > a relative offset and add the VM state offset to it internally inside > the qcow2 code. Looks good to me and makes the interface nicer. Maybe we could use the opportunity to change the function names to something like bdrv_vmstate_read/write? get/put_buffer is quite unspecific, it could mean anything. Kevin