From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOXge-0002PE-EB for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:59:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOXgZ-0002KV-Mh for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:59:52 -0400 Received: from [199.232.76.173] (port=50628 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOXgZ-0002KF-Ib for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:59:47 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:41369) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MOXgZ-00067M-5y for qemu-devel@nongnu.org; Wed, 08 Jul 2009 09:59:47 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e9.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n68DlQ3F030492 for ; Wed, 8 Jul 2009 09:47:26 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n68DxjWG219358 for ; Wed, 8 Jul 2009 09:59:45 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n68Dxj3j006446 for ; Wed, 8 Jul 2009 09:59:45 -0400 Message-ID: <4A54A64E.7080101@us.ibm.com> Date: Wed, 08 Jul 2009 08:59:42 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot References: <20090707192631.GQ11590@us.ibm.com> <20090708075601.GJ28046@redhat.com> <4A549990.2060205@us.ibm.com> <20090708132623.GN26640@redhat.com> <4A54A367.3010603@us.ibm.com> <20090708135607.GO26640@redhat.com> In-Reply-To: <20090708135607.GO26640@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Ryan Harper , qemu-devel@nongnu.org, Gleb Natapov Daniel P. Berrange wrote: > That suffers from the same problem as a system_reboot command in that > the guest may never start the shutdown. If that's an acceptable > limitation, then we might as well implement it directly in QEMU as > system_reboot so its easily available to everyone. Make 'system_reboot' > take an optional timeout arg (default to 60 seconds) after which it > cancels its plans. > That's a heuristic and we tend to avoid implementing heuristics in QEMU. It's really the role of a management tool to make policy decisions. -- Regards, Anthony Liguori