From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sanitize ->bdrv_get_buffer / ->bdrv_put_buffer calling conventions
Date: Wed, 08 Jul 2009 16:57:09 +0200 [thread overview]
Message-ID: <4A54B3C5.5070806@redhat.com> (raw)
In-Reply-To: <20090708140117.GA24544@lst.de>
Christoph Hellwig schrieb:
> On Wed, Jul 08, 2009 at 03:46:15PM +0200, Kevin Wolf wrote:
>> Christoph Hellwig schrieb:
>>> The VM state offset is an concept internal to the image format, it
>>> doesn't even have to be a traditional linear offset. So change the
>>> ->bdrv_get_buffer / ->bdrv_put_buffer calling convention to always pass
>>> a relative offset and add the VM state offset to it internally inside
>>> the qcow2 code.
>> Looks good to me and makes the interface nicer. Maybe we could use the
>> opportunity to change the function names to something like
>> bdrv_vmstate_read/write? get/put_buffer is quite unspecific, it could
>> mean anything.
>
> Does this one looks good?
I think it does.
Kevin
prev parent reply other threads:[~2009-07-08 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 17:34 [Qemu-devel] [PATCH] sanitize ->bdrv_get_buffer / ->bdrv_put_buffer calling conventions Christoph Hellwig
2009-07-08 13:46 ` Kevin Wolf
2009-07-08 14:01 ` Christoph Hellwig
2009-07-08 14:57 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A54B3C5.5070806@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).