From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOYbL-0003pa-Dj
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 10:58:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOYbG-0003lG-IT
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 10:58:26 -0400
Received: from [199.232.76.173] (port=56204 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOYbG-0003l1-D9
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 10:58:22 -0400
Received: from mx2.redhat.com ([66.187.237.31]:57668)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MOYbF-0000hx-OQ
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 10:58:22 -0400
Message-ID: <4A54B3C5.5070806@redhat.com>
Date: Wed, 08 Jul 2009 16:57:09 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] sanitize ->bdrv_get_buffer /
	->bdrv_put_buffer calling conventions
References: <20090707173401.GA5145@lst.de> <4A54A327.9020501@redhat.com>
	<20090708140117.GA24544@lst.de>
In-Reply-To: <20090708140117.GA24544@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

Christoph Hellwig schrieb:
> On Wed, Jul 08, 2009 at 03:46:15PM +0200, Kevin Wolf wrote:
>> Christoph Hellwig schrieb:
>>> The VM state offset is an concept internal to the image format, it
>>> doesn't even have to be a traditional linear offset.  So change the
>>> ->bdrv_get_buffer / ->bdrv_put_buffer calling convention to always pass
>>> a relative offset and add the VM state offset to it internally inside
>>> the qcow2 code.
>> Looks good to me and makes the interface nicer. Maybe we could use the
>> opportunity to change the function names to something like
>> bdrv_vmstate_read/write? get/put_buffer is quite unspecific, it could
>> mean anything.
> 
> Does this one looks good?

I think it does.

Kevin