From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOYix-0003vA-WE
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:06:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOYit-0003rO-49
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:06:19 -0400
Received: from [199.232.76.173] (port=51231 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOYis-0003rD-U0
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:06:14 -0400
Received: from fwil.voltaire.com ([193.47.165.2]:13114 helo=exil.voltaire.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <ogerlitz@voltaire.com>) id 1MOYis-0002Cs-B0
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:06:14 -0400
Message-ID: <4A54B5E1.8090001@Voltaire.com>
Date: Wed, 08 Jul 2009 18:06:09 +0300
From: Or Gerlitz <ogerlitz@Voltaire.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] net: add raw backend
References: <Pine.LNX.4.64.0907011844470.32248@zuben.voltaire.com>	<20090702154354.GA27022@redhat.com>
	<4A535F93.7090305@Voltaire.com> <20090707144932.GA8153@redhat.com>
In-Reply-To: <20090707144932.GA8153@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Herbert Xu <herbert.xu@redhat.com>, qemu-devel@nongnu.org

Michael S. Tsirkin wrote:
> On Tue, Jul 07, 2009 at 05:45:39PM +0300, Or Gerlitz wrote:
>> Michael S. Tsirkin wrote:

>>> It might be a good idea to request aux data and verify that checksum is set, 
>>> calculate it if not. this will make it possible to bind to a local device as well.

>> I am still not sure to follow the checksum reporting of the af_packet kernel code

> See comment in qemu-kvm about dhclient as an example.

yes, some sort of "host software checksum offload" when using packet socket make sense. I wasn't sure when the af_packet kernel code does report on "checksum okay", it only checks for "ip_summed == CHECKSUM_PARTIAL".

Or.