From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOYqN-0000dO-N4 for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:13:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOYqI-0000Z3-UR for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:13:59 -0400 Received: from [199.232.76.173] (port=49819 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOYqI-0000Yu-KM for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:13:54 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37616) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MOYqI-0003cg-5y for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:13:54 -0400 Message-ID: <4A54B848.8060605@redhat.com> Date: Wed, 08 Jul 2009 18:16:24 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot References: <20090707192631.GQ11590@us.ibm.com> <20090708075601.GJ28046@redhat.com> <4A549990.2060205@us.ibm.com> <4A54A77D.2060400@redhat.com> <20090708141058.GQ26640@redhat.com> In-Reply-To: <20090708141058.GQ26640@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Anthony Liguori , Ryan Harper , qemu-devel@nongnu.org, Gleb Natapov On 07/08/2009 05:10 PM, Daniel P. Berrange wrote: >>> Indeed. This is what has kept me from applying this but I just can't >>> think of any better solution. >>> >>> Any ideas? >>> >>> The drive behind implementing this feature is so that we can implement >>> a proper virDomainReboot in libvirt. >>> >>> >> How does Xen hvm implement it? >> > > You have to install the Xen paravirt drivers, so Xen HVM handles graceful > shutdown/reboot in the same way as pure Xen paravirt. They watch a flag > in xenstore and invoke shutdown -r / -h according to the flag. > What happens if the driver is not installed? The guest just keeps going, right? What's the libvirt motivation for the feature? -- error compiling committee.c: too many arguments to function