From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MObcG-0000pw-De
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 14:11:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MObcB-0000n7-TR
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 14:11:36 -0400
Received: from [199.232.76.173] (port=35306 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MObcB-0000n0-Nk
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 14:11:31 -0400
Received: from mx2.redhat.com ([66.187.237.31]:44813)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MObcB-0003OM-D1
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 14:11:31 -0400
Message-ID: <4A54E160.9000900@redhat.com>
Date: Wed, 08 Jul 2009 21:11:44 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands
References: <1247064963.3270.63.camel@blaa>		<1247065048-15706-1-git-send-email-markmc@redhat.com>		<1247065048-15706-2-git-send-email-markmc@redhat.com>		<1247065048-15706-3-git-send-email-markmc@redhat.com>		<4A54BABD.3040903@redhat.com>
	<1247069035.3270.82.camel@blaa> <4A54C634.30007@redhat.com>
	<4A54E0B3.8090305@codemonkey.ws>
In-Reply-To: <4A54E0B3.8090305@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org

On 07/08/2009 09:08 PM, Anthony Liguori wrote:
> Avi Kivity wrote:
>> I'd prefer the communication layer to queue fds and getfd to dequeue 
>> them.
>
> How many do you queue?  The correct answer is one, btw ;-)

You queue as many as you receive, and you dequeue as many getfd commands 
as you get.

Nothing prevents the client from sending two getfd commands in a single 
packet.  We can either support it or start writing detailed 
documentation and handle the bug reports when people don't read it.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.