From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOtme-0002sP-St
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:35:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOtmY-0002r9-BT
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:35:31 -0400
Received: from [199.232.76.173] (port=33444 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOtmX-0002qy-TZ
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:35:26 -0400
Received: from qw-out-1920.google.com ([74.125.92.146]:5997)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MOtmX-0007WT-M9
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:35:25 -0400
Received: by qw-out-1920.google.com with SMTP id 5so33276qwc.4
	for <qemu-devel@nongnu.org>; Thu, 09 Jul 2009 06:35:25 -0700 (PDT)
Message-ID: <4A55F21A.7060704@codemonkey.ws>
Date: Thu, 09 Jul 2009 08:35:22 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3 v2] Add a pc-0-10 machine type for
	compatibility with 0.10.x
References: <1244821292.30522.56.camel@blaa>	
	<20090615124101.GH6351@redhat.com>	 <4A364381.401@redhat.com>	
	<4A364401.6010500@codemonkey.ws>	 <4A3647FB.9010808@redhat.com>	
	<4A364B53.9080007@codemonkey.ws>	 <4A364FE0.40204@redhat.com>	
	<4A3651EB.3070204@codemonkey.ws>	 <4A36555A.4090303@redhat.com>	
	<4A3659A0.3050108@codemonkey.ws>	 <4A366348.1030202@redhat.com>	
	<1245083229.3222.103.camel@blaa>	 <4A368F12.2090504@codemonkey.ws>	
	<1246964898.2836.38.camel@blaa>	 <1246964950.2836.39.camel@blaa>	
	<1246964998.2836.40.camel@blaa>	
	<1246965054.2836.41.camel@blaa>	 <4A5338FC.9030301@redhat.com>	
	<1247049984.3270.52.camel@blaa>	
	<1247050083.3270.54.camel@blaa>	 <4A54986D.301@redhat.com>	
	<4A54A2B0.6050605@codemonk! ey.ws>	
	<4A54A895.5090501@redhat.com>	 <1247065728.3270.65.camel@blaa>
	<4A54EE87.2000508@redhat.com>	 <4A55136E.6050508@codemonkey.ws>
	<4A55A29A.9020202@redhat.com> <1247128775.22231.15.camel@blaa>
	<4A55B2E8.4060109@redhat.com> <4A55BFE7.4070402@redhat.com>
In-Reply-To: <4A55BFE7.4070402@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

Gerd Hoffmann wrote:
>   Hi,
>
>> I'd prefer to not introduce those virtio-$type-pci-$version devices in
>> the first place. It isn't hard to write up something qdev based. Only
>> problem is it will depend on lots of not-yet merged qdev patches.
>
> To back that with some code here is a quick patch.  Not splitted up 
> yet.  Only virtio-blk is handled for demonstration purposes.
>
> Will not apply cleanly as it depends on both posted and not-yet posted 
> patches in my patch queue.  Once my qdev properties patch is in it 
> should be easy to rebase to upstream/master though.

It came out looking pretty good.  The literal syntax is new to me:

+    .compat_props = (CompatProperty[]) {
+        {


I assume this is a GCC-ism?

Regards,

Anthony Liguori