From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOtsb-0004oq-4z
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:41:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOtsT-0004km-Lp
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:41:38 -0400
Received: from [199.232.76.173] (port=45424 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOtsR-0004kU-77
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:41:31 -0400
Received: from mx2.redhat.com ([66.187.237.31]:44800)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MOtsQ-0008Vo-Eg
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:41:30 -0400
Message-ID: <4A55F30C.9000502@redhat.com>
Date: Thu, 09 Jul 2009 15:39:24 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: add driver class support.
References: <1247144544-8885-1-git-send-email-kraxel@redhat.com>
	<200907091419.11248.paul@codesourcery.com>
In-Reply-To: <200907091419.11248.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On 07/09/09 15:19, Paul Brook wrote:
> On Thursday 09 July 2009, Gerd Hoffmann wrote:
>>    Hi,
>>
>> This patch series brings driver classes to qdev.
>
> I'm not sure this is a good idea. You should be able to figure it out from the
> device properties.

I don't think this will work out in the general case.  Some devices have 
properties which can be used for that, i.e. network cards have a mac 
address (no attribute yet but I expect it will come some day).  Not 
every device class has specific properties you can use to identify them 
though.  How would you identify a sound card for example?

> Plus there's no reason why a device can't implement
> multiple "classes" of device.

Hmm, good point.  How about using a bitmap then?

cheers,
   Gerd