From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOtyH-0008Jj-5u
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:47:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOtyB-0008D7-Oi
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:47:32 -0400
Received: from [199.232.76.173] (port=49690 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOtyB-0008Ce-4B
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:47:27 -0400
Received: from mx2.redhat.com ([66.187.237.31]:54837)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MOtyA-00012k-GU
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:47:26 -0400
Message-ID: <4A55F4E6.9030807@redhat.com>
Date: Thu, 09 Jul 2009 15:47:18 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3 v2] Add a pc-0-10 machine type for
	compatibility with 0.10.x
References: <1244821292.30522.56.camel@blaa>	 <4A364381.401@redhat.com>	
	<4A364401.6010500@codemonkey.ws>	 <4A3647FB.9010808@redhat.com>	
	<4A364B53.9080007@codemonkey.ws>	 <4A364FE0.40204@redhat.com>	
	<4A3651EB.3070204@codemonkey.ws>	 <4A36555A.4090303@redhat.com>	
	<4A3659A0.3050108@codemonkey.ws>	 <4A366348.1030202@redhat.com>	
	<1245083229.3222.103.camel@blaa>	 <4A368F12.2090504@codemonkey.ws>	
	<1246964898.2836.38.camel@blaa>	 <1246964950.2836.39.camel@blaa>	
	<1246964998.2836.40.camel@blaa>	
	<1246965054.2836.41.camel@blaa>	 <4A5338FC.9030301@redhat.com>	
	<1247049984.3270.52.camel@blaa>	
	<1247050083.3270.54.camel@blaa>	 <4A54986D.301@redhat.com>	
	<4A54A2B0.6050605@codemonk! ey.ws>	
	<4A54A895.5090501@redhat.com>	 <1247065728.3270.65.camel@blaa>
	<4A54EE87.2000508@redhat.com>	 <4A55136E.6050508@codemonkey.ws>
	<4A55A29A.9020202@redhat.com>	 <1247128775.22231.15.camel@blaa>
	<4A55B2E8.4060109@redhat.com>	 <4A55BFE7.4070402@redhat.com>
	<1247146315.22231.128.camel@blaa>
In-Reply-To: <1247146315.22231.128.camel@blaa>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On 07/09/09 15:31, Mark McLoughlin wrote:
>> +static QEMUMachine pc_machine_v0_10 = {
>> +    .name = "pc-0.10",
>> +    .desc = "Standard PC, qemu 0.10",
>> +    .init = pc_init_pci,
>> +    .max_cpus = 255,
>> +    .compat_props = (CompatProperty[]) {
>> +        {
>> +            .driver   = "virtio-blk-pci",
>> +            .property = "class",
>> +            .value    = "0x0180", /* PCI_CLASS_STORAGE_OTHER */
>> +        },
>> +        { /* end of list */ }
>> +    },
>> +};
>
> I did actually experiment with something similar to this, but backed off
> because I didn't like putting such details (i.e. the class value) in
> hw/pc.c rather than keeping them self contained in the driver code.
> Especially since it'll have to be replicated for every machine which can
> use the device.

We don't need to have the list inline.  We can have

CompatProperty compat_qemu_0_10[] {
     [ properties here ]
};

somewhere and then just reference it like this:

static QEMUMachine pc_machine_v0_10 = {
     .name = "pc-0.10",
     [ ... ]
     .compat_props = &compat_qemu_0_10,
};

from multiple machine types.

cheers,
   Gerd