From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOu6B-0006a4-7X for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:55:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOu66-0006Wo-0D for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:55:42 -0400 Received: from [199.232.76.173] (port=53153 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOu65-0006WV-DZ for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:55:37 -0400 Received: from mx2.redhat.com ([66.187.237.31]:59353) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MOu64-0002Kp-Vc for qemu-devel@nongnu.org; Thu, 09 Jul 2009 09:55:37 -0400 Message-ID: <4A55F6C8.9050804@redhat.com> Date: Thu, 09 Jul 2009 15:55:20 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3 v2] Add a pc-0-10 machine type for compatibility with 0.10.x References: <1244821292.30522.56.camel@blaa> <4A364381.401@redhat.com> <4A364401.6010500@codemonkey.ws> <4A3647FB.9010808@redhat.com> <4A364B53.9080007@codemonkey.ws> <4A364FE0.40204@redhat.com> <4A3651EB.3070204@codemonkey.ws> <4A36555A.4090303@redhat.com> <4A3659A0.3050108@codemonkey.ws> <4A366348.1030202@redhat.com> <1245083229.3222.103.camel@blaa> <4A368F12.2090504@codemonkey.ws> <1246964898.2836.38.camel@blaa> <1246964950.2836.39.camel@blaa> <1246964998.2836.40.camel@blaa> <1246965054.2836.41.camel@blaa> <4A5338FC.9030301@redhat.com> <1247049984.3270.52.camel@blaa> <1247050083.3270.54.camel@blaa> <4A54986D.301@redhat.com> <4A54A2B0.6050605@codemonk! ey.ws> <4A54A895.5090501@redhat.com> <1247065728.3270.65.camel@blaa> <4A54EE87.2000508@redhat.com> <4A55136E.6050508@codemonkey.ws> <4A55A29A.9020202@redhat.com> <1247128775.22231.15.camel@blaa> <4A55B2E8.4060109@redhat.com> <4A55BFE7.4070402@redhat.com> <4A55F21A.7060704@codemonkey.ws> In-Reply-To: <4A55F21A.7060704@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , Avi Kivity , qemu-devel@nongnu.org On 07/09/09 15:35, Anthony Liguori wrote: > It came out looking pretty good. The literal syntax is new to me: > > + .compat_props = (CompatProperty[]) { > + { > > I assume this is a GCC-ism? Not sure. Could also be C99. It is new to me too. One of Pauls patches brought it in (check hw/syborg_timer.c, pretty close to the bottom). I found it very useful for building up static data structures and picked it up. cheers, Gerd