qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: add driver class support.
Date: Thu, 09 Jul 2009 16:26:43 +0200	[thread overview]
Message-ID: <4A55FE23.4090205@redhat.com> (raw)
In-Reply-To: <200907091448.59926.paul@codesourcery.com>

On 07/09/09 15:48, Paul Brook wrote:
> On Thursday 09 July 2009, Gerd Hoffmann wrote:

>> I don't think this will work out in the general case.  Some devices have
>> properties which can be used for that, i.e. network cards have a mac
>> address (no attribute yet but I expect it will come some day).  Not
>> every device class has specific properties you can use to identify them
>> though.  How would you identify a sound card for example?
>
> Ok, put it annother way: Why do you need to identify them? Why would libvirt
> care whether a device is (say) a sound card or a VGA adapter?

Because libvirt-based applications want present that to the user?

The usual GUI workflow for adding devices is a two-step process:  First 
pick the device class, then pick the actual device from a (short) list.

> In principle
> there's no reason why you shouldn't have many or none of both.

Sure.  But when you ask virt-manager to add a sound card to your virtual 
machine you don't want to have a VGA adapter in the list of possible 
devices.

> IMHO the only reason we have the current grouping is because it's forced on us
> by the various commandline options which mix host and machine configuration.

That is actually another reason:  Allow easy support of legacy command 
line options.  Once all sound cards are converted to qdev '-soundhw ?' 
could list all sound cards by just walking the driver list and print the 
ones with class = SOUND.

cheers,
   Gerd

  reply	other threads:[~2009-07-09 14:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 13:02 [Qemu-devel] [PATCH 0/5] qdev: add driver class support Gerd Hoffmann
2009-07-09 13:02 ` [Qemu-devel] [PATCH 1/5] qdev/class: core Gerd Hoffmann
2009-07-09 13:02 ` [Qemu-devel] [PATCH 2/5] qdev/class: tag sound Gerd Hoffmann
2009-07-09 13:02 ` [Qemu-devel] [PATCH 3/5] qdev/class: tag network Gerd Hoffmann
2009-07-09 13:02 ` [Qemu-devel] [PATCH 4/5] qdev/class: helper function to get a list of drivers Gerd Hoffmann
2009-07-09 13:02 ` [Qemu-devel] [PATCH 5/5] qdev/class: make pci_nic_init() use qdev's device list Gerd Hoffmann
2009-07-09 13:19 ` [Qemu-devel] [PATCH 0/5] qdev: add driver class support Paul Brook
2009-07-09 13:39   ` Gerd Hoffmann
2009-07-09 13:48     ` Paul Brook
2009-07-09 14:26       ` Gerd Hoffmann [this message]
2009-07-09 15:46         ` Anthony Liguori
2009-07-10  7:50           ` Gerd Hoffmann
2009-07-10  9:46             ` Paul Brook
2009-07-10  9:59               ` Gerd Hoffmann
2009-07-10 10:13                 ` Paul Brook
2009-07-10 10:29                   ` Gerd Hoffmann
2009-07-09 14:34   ` Filip Navara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A55FE23.4090205@redhat.com \
    --to=kraxel@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).