From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOuqf-00007k-VO
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 10:43:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOuqa-0008Tl-Ow
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 10:43:45 -0400
Received: from [199.232.76.173] (port=52685 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOuqa-0008TX-Fu
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 10:43:40 -0400
Received: from qw-out-1920.google.com ([74.125.92.148]:33200)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MOuqX-0003e6-Ar
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 10:43:37 -0400
Received: by qw-out-1920.google.com with SMTP id 5so52291qwc.4
	for <qemu-devel@nongnu.org>; Thu, 09 Jul 2009 07:43:36 -0700 (PDT)
Message-ID: <4A560213.4000106@codemonkey.ws>
Date: Thu, 09 Jul 2009 09:43:31 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3] add live dumping capability
References: <1247140059-5034-1-git-send-email-pbonzini@redhat.com>
	<1247140059-5034-4-git-send-email-pbonzini@redhat.com>
	<4A55F57B.3030306@codemonkey.ws> <4A55F95A.8080409@redhat.com>
In-Reply-To: <4A55F95A.8080409@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Paolo Bonzini wrote:
>>> With the previous cleanups in place, it is easy to trigger
>>> restart when the state machine goes from the COMPLETING to the
>>> COMPLETED state. Besides this, the patch is just simple
>>> scaffolding for the monitor command and to migrate to a file
>>> rather than a pipe (which is a bit simpler because we do not
>>> need non-blocking I/O).
>>
>> Then this isn't live migration.
>
> Sorry, I cannot understand this remark.

You're using blocking I/O which will cause the guest to pause while disk 
I/O is happening.

If you want to see this in action, before running dump, type 
"migrate_set_rate 10G" in the monitor.  It only appears live now because 
the default rate limit is pretty close to the write speed of a typical disk.

Regards,

Anthony Liguori