From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOvNh-0003j9-5w for qemu-devel@nongnu.org; Thu, 09 Jul 2009 11:17:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOvNc-0003hC-HU for qemu-devel@nongnu.org; Thu, 09 Jul 2009 11:17:52 -0400 Received: from [199.232.76.173] (port=42431 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOvNc-0003h1-B3 for qemu-devel@nongnu.org; Thu, 09 Jul 2009 11:17:48 -0400 Received: from mx2.redhat.com ([66.187.237.31]:36690) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MOvNc-0002Bt-0T for qemu-devel@nongnu.org; Thu, 09 Jul 2009 11:17:48 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n69FHlSp027168 for ; Thu, 9 Jul 2009 11:17:47 -0400 Message-ID: <4A560A17.6020202@redhat.com> Date: Thu, 09 Jul 2009 17:17:43 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 5/5] qdev/compat: virtio-net-pci 0.10 compatibility. References: <1247144553-8951-1-git-send-email-kraxel@redhat.com> <1247144553-8951-6-git-send-email-kraxel@redhat.com> <20090709144004.GB26895@redhat.com> In-Reply-To: <20090709144004.GB26895@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 07/09/09 16:40, Michael S. Tsirkin wrote: > The number of vectors is part of hardware config so it's not a good idea > to use a binary property here. Since<= vectors is not a legal msi > configuration, it's enough to implement a "vectors" property instead: > virtio already interprets zero vectors as no msi. This also matches > command line/monitor syntax, which is a good thing. Ok, it makes sense to have a vectors property then. Will rewrite the patch. cheers, Gerd