From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOvte-0005S8-2j
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 11:50:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOvtX-0005IE-2o
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 11:50:51 -0400
Received: from [199.232.76.173] (port=55158 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOvtW-0005Gf-L2
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 11:50:46 -0400
Received: from rv-out-0708.google.com ([209.85.198.251]:13654)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MOvtU-0008VR-Ja
	for qemu-devel@nongnu.org; Thu, 09 Jul 2009 11:50:45 -0400
Received: by rv-out-0708.google.com with SMTP id b17so54565rvf.22
	for <qemu-devel@nongnu.org>; Thu, 09 Jul 2009 08:50:33 -0700 (PDT)
Message-ID: <4A5611C4.8000503@codemonkey.ws>
Date: Thu, 09 Jul 2009 10:50:28 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/5] qdev/compat: virtio-blk-pci 0.10
	compatibility.
References: <1247144553-8951-1-git-send-email-kraxel@redhat.com>	<1247144553-8951-4-git-send-email-kraxel@redhat.com>
	<20090709145215.GC26895@redhat.com>
In-Reply-To: <20090709145215.GC26895@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

Michael S. Tsirkin wrote:
> Hi Gerd,
> a couple of questions:
>
> On Thu, Jul 09, 2009 at 03:02:31PM +0200, Gerd Hoffmann wrote:
>   
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>>  hw/pc.c         |    5 +++++
>>  hw/virtio-pci.c |   22 ++++++++++++++--------
>>  2 files changed, 19 insertions(+), 8 deletions(-)
>>
>> diff --git a/hw/pc.c b/hw/pc.c
>> index 6ba6b25..0574283 100644
>> --- a/hw/pc.c
>> +++ b/hw/pc.c
>> @@ -1463,6 +1463,11 @@ static QEMUMachine pc_machine_v0_10 = {
>>      .init = pc_init_pci,
>>      .max_cpus = 255,
>>      .compat_props = (CompatProperty[]) {
>> +        {
>> +            .driver   = "virtio-blk-pci",
>> +            .property = "class",
>> +            .value    = "0x0180", /* PCI_CLASS_STORAGE_OTHER */
>>     
>
> it seems annoying that we can't use the symbolic name. Ideas how to fix this?
>   

#define strify_i(a) # a
#define strify(a) strify_i(a)

.value = strify(PCI_CLASS_STORAGE_OTHER),

Will expand to:

.value = "0x0180",

Regards,

Anthony Liguori