From: Anthony Liguori <anthony@codemonkey.ws>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-io: small cleanups for the aio code
Date: Thu, 09 Jul 2009 15:02:59 -0500 [thread overview]
Message-ID: <4A564CF3.2040005@codemonkey.ws> (raw)
In-Reply-To: <20090701112018.GA10455@lst.de>
Christoph Hellwig wrote:
> if (ctx->Pflag) {
> - void *cmp_buf = malloc(total);
> + void *cmp_buf = malloc(ctx->qiov.size);
>
> - memset(cmp_buf, ctx->pattern, total);
> - if (memcmp(ctx->buf, cmp_buf, total)) {
> + memset(cmp_buf, ctx->pattern, ctx->qiov.size);
> + if (memcmp(ctx->buf, cmp_buf, ctx->qiov.size)) {
> printf("Pattern verification failed at offset %lld, "
> "%d bytes\n",
> - (long long) ctx->offset, total);
> + (long long) ctx->offset, ctx->qiov.size);
>
This breaks the build because ctx->qiov.size is a size_t and your format
parameter is a %d.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-07-09 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 11:20 [Qemu-devel] [PATCH 1/2] qemu-io: small cleanups for the aio code Christoph Hellwig
2009-07-09 20:02 ` Anthony Liguori [this message]
2009-07-10 1:37 ` Christoph Hellwig
2009-07-10 10:20 ` malc
2009-07-10 10:47 ` Christoph Hellwig
2009-07-10 13:04 ` Jamie Lokier
2009-07-10 15:25 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A564CF3.2040005@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).