From: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>
To: Dinesh Subhraveti <subhraveti@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [SOLUTION] "i8042.c: No controller found" ->OS sees no keyboard if I type "in BIOS"
Date: Fri, 10 Jul 2009 09:21:17 +0100 [thread overview]
Message-ID: <4A56F9FD.5070208@siriusit.co.uk> (raw)
In-Reply-To: <h35lah$le7$1@ger.gmane.org>
Dinesh Subhraveti wrote:
> Sorry for the duplicate message above (mail server was taking hours to post,
> and I got impatient...)
>
> Changing PS2_QUEUE_SIZE to 15 and the "reserved space" to 8 fixes the
> problem for me:
>
> diff --git a/hw/ps2.c b/hw/ps2.c
> index fb77005..51a3ab8 100644
> --- a/hw/ps2.c
> +++ b/hw/ps2.c
> @@ -70,7 +70,7 @@
> #define MOUSE_STATUS_ENABLED 0x20
> #define MOUSE_STATUS_SCALE21 0x10
>
> -#define PS2_QUEUE_SIZE 256
> +#define PS2_QUEUE_SIZE 15
>
> typedef struct {
> uint8_t data[PS2_QUEUE_SIZE];
> @@ -346,7 +346,7 @@ static void ps2_mouse_event(void *opaque,
> s->mouse_buttons = buttons_state;
>
> if (!(s->mouse_status & MOUSE_STATUS_REMOTE) &&
> - (s->common.queue.count < (PS2_QUEUE_SIZE - 16))) {
> + (s->common.queue.count < (PS2_QUEUE_SIZE - 8))) {
> for(;;) {
> /* if not remote, send event. Multiple events are sent if
> too big deltas */
>
> Both keyboard and mouse remain responsive after reboot, no matter how much I
> type / move the mouse during reboot.
>
> Any comments?
Hi Dinesh,
Thanks for this. I've applied this patch to the copy of kvm which hosts
our NT4 virtual which has been experiencing random mouse/keyboard input
problems. Fingers crossed that your patch will fix this issue for good...
ATB,
Mark.
--
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063
next prev parent reply other threads:[~2009-07-10 8:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 13:57 [Qemu-devel] "i8042.c: No controller found" -> OS sees no keyboard if I type "in BIOS" Tomasz Chmielewski
2009-05-20 9:30 ` Tomasz Chmielewski
2009-05-20 13:30 ` [Qemu-devel] [SOLUTION] " Tomasz Chmielewski
2009-06-07 4:04 ` Marcelo Tosatti
2009-06-08 13:51 ` Tomasz Chmielewski
2009-06-08 14:13 ` Tomasz Chmielewski
2009-06-08 14:30 ` Marcelo Tosatti
2009-06-08 15:11 ` Tomasz Chmielewski
2009-06-08 15:48 ` Mark Cave-Ayland
2009-06-23 12:27 ` Mark Cave-Ayland
2009-06-08 14:59 ` Avi Kivity
2009-06-08 15:08 ` Tomasz Chmielewski
2009-06-08 15:28 ` Paul Brook
2009-07-08 21:08 ` [Qemu-devel] " Dinesh Subhraveti
2009-07-09 1:07 ` Dinesh Subhraveti
2009-07-09 20:52 ` [Qemu-devel] Re: [SOLUTION] "i8042.c: No controller found" ->OS " Dinesh Subhraveti
2009-07-10 8:21 ` Mark Cave-Ayland [this message]
2009-07-10 21:45 ` Dinesh Subhraveti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A56F9FD.5070208@siriusit.co.uk \
--to=mark.cave-ayland@siriusit.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=subhraveti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).