From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPCvM-0008CB-8o for qemu-devel@nongnu.org; Fri, 10 Jul 2009 06:01:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPCvH-00087i-6k for qemu-devel@nongnu.org; Fri, 10 Jul 2009 06:01:47 -0400 Received: from [199.232.76.173] (port=33372 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPCvG-00087O-RP for qemu-devel@nongnu.org; Fri, 10 Jul 2009 06:01:43 -0400 Received: from mx2.redhat.com ([66.187.237.31]:51098) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MPCvG-00007G-80 for qemu-devel@nongnu.org; Fri, 10 Jul 2009 06:01:42 -0400 Message-ID: <4A571102.4070503@redhat.com> Date: Fri, 10 Jul 2009 11:59:30 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: add driver class support. References: <1247144544-8885-1-git-send-email-kraxel@redhat.com> <4A5610E6.80507@codemonkey.ws> <4A56F2AA.4060905@redhat.com> <200907101046.22016.paul@codesourcery.com> In-Reply-To: <200907101046.22016.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On 07/10/09 11:46, Paul Brook wrote: >>> But we also >>> have to consider the case where a single device exposes multiple types >>> of capabilities. >> I think we already agreed to move to a bitmap model to handle that. > > I still think this is best done via properties, rather than as a separate > feature. Properties really don't fit here IMO. Property values belong to a device *instance*, not to a device *driver*. If you stick two e1000 network cards into your virtual machine both instances will have different pci bus and mac addresses. They wouldn't have different device capabilities though. cheers, Gerd