From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPFKC-0002BX-Nf for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:35:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPFK7-00027O-0M for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:35:35 -0400 Received: from [199.232.76.173] (port=37581 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPFK5-00026y-Pz for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:35:30 -0400 Received: from outbound-dub.frontbridge.com ([213.199.154.16]:34739 helo=IE1EHSOBE002.bigfish.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16) (Exim 4.60) (envelope-from ) id 1MPFK5-0002nz-6k for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:35:29 -0400 Message-ID: <4A573568.70800@amd.com> Date: Fri, 10 Jul 2009 14:34:48 +0200 From: Andre Przywara MIME-Version: 1.0 Subject: Re: [Qemu-devel] EXT3-fs error on Git HEAD References: <20090629095032.f729525f.mle+tools@mega-nerd.com> <20090629134201.4115de43.mle+tools@mega-nerd.com> <1246292869.13041.342.camel@mendozza.osrc.amd.com> <4A49D5E2.4070705@redhat.com> In-Reply-To: <4A49D5E2.4070705@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Frank Arnold , qemu-devel@nongnu.org Hi, can someone please apply the patch below from Kevin? I know that QCOW1 is kind of deprecated, but this should not mean that such serious errors stay unfixed. I have this patch in all, well: almost :-( of my branches and would love to see it upstream. And yes, we are about to convert our images to QCOW2... Thanks! Regards, Andre. Kevin Wolf wrote: > Frank Arnold schrieb: >> Am Montag, den 29.06.2009, 13:42 +1000 schrieb Erik de Castro Lopo: >>> Erik de Castro Lopo wrote: >>> >>>> I have a number of Qemu VMs. Over the weekend I updated to the latest >>>> Git head and now two of my VMs (one i386 and one x86-64) are having >>>> disk errors. Strange thing is, my arm VM is working flawlessly. >>> These VM disk images are all qcow. The i386 and x86-64 ones I converted >>> to qcow2 and they now work fine. The arm one is still qcow and is still >>> working fine. >> We're seeing the same on qemu-kvm.git. I tracked it down to following >> commits: >> >> commit c16b5a2ca0b186de618654a576bdad9cdd2d1ab2 >> Author: Christoph Hellwig >> Date: Mon May 25 12:37:32 2009 +0200 >> >> fully split aio_pool from BlockDriver >> >> commit ad53089b0d0b4bc0731d978e5713365e1a91ba74 >> Author: Christoph Hellwig >> Date: Mon May 25 15:45:37 2009 +0200 >> >> qcow: add qcow_aio_setup helper > > This one has an obvious bug. Does the following change help? > > diff --git a/block/qcow.c b/block/qcow.c > index 55a68a6..7fc85ae 100644 > --- a/block/qcow.c > +++ b/block/qcow.c > @@ -723,7 +723,7 @@ static BlockDriverAIOCB > *qcow_aio_writev(BlockDriverState *bs, > > s->cluster_cache_offset = -1; /* disable compressed cache */ > > - acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 0); > + acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 1); > if (!acb) > return NULL; > > Kevin > > > -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 448 3567 12 ----to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy; Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632