Re: [Qemu-devel] [PATCH] qemu-iotests: make a few more tests generic

[Anthony Liguori <aliguori@us.ibm.com>]

Kevin Wolf wrote:
> This problem has already be found. Avi's patch from almost three weeks
> ago fixes it.
>   

Christoph posted an alternative patch and there didn't seem to be a 
consensus on the thread about what solution was the best one.  See 
http://article.gmane.org/gmane.comp.emulators.qemu/46032/match=block+clean+up+after.  
It's also up to the submitter to keep track of their patches.  If they 
think one should be applied that hasn't been, they need to follow up on 
it.  The only way to scale here is to push as much work as possible to 
the outer-most nodes.

> It really starts to get annoying. How am I supposed to work with commits
> only every other week (which is bad enough) and then patches are
> forgotten and probably won't be merged before another two weeks? I guess
> I should manage some local tree with fixes myself and move away from
> basing my work on git master...
>   

Complaining is all well and good but it doesn't help the problem.  Your 
particular compliant is about a patch that fixes a problem another patch 
introduced.  Greater patch velocity == greater instability because there 
isn't an adequate amount of testing going on.  It takes time to do 
proper testing and review of patches.

It would be very helpful if you proactively tested/reviewed patches on 
the mailing list and then commented appropriately.  People adding 
Tested-by tags to patches on the list would be a great help for instance.

-- 
Regards,

Anthony Liguori