From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPFa6-0000AR-4M for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:52:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPFa0-0008VD-PG for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:52:01 -0400 Received: from [199.232.76.173] (port=59849 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPFa0-0008V3-Ar for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:51:56 -0400 Received: from mail-qy0-f174.google.com ([209.85.221.174]:38169) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MPFZz-0007II-UX for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:51:56 -0400 Received: by qyk4 with SMTP id 4so650367qyk.4 for ; Fri, 10 Jul 2009 05:51:55 -0700 (PDT) Message-ID: <4A573968.9050509@codemonkey.ws> Date: Fri, 10 Jul 2009 07:51:52 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3] add live dumping capability References: <1247140059-5034-1-git-send-email-pbonzini@redhat.com> <1247140059-5034-4-git-send-email-pbonzini@redhat.com> <4A55F57B.3030306@codemonkey.ws> <4A55F95A.8080409@redhat.com> <4A560213.4000106@codemonkey.ws> <4A56FC8A.3030700@redhat.com> In-Reply-To: <4A56FC8A.3030700@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Paolo Bonzini wrote: > Unfortunately non-blocking I/O does not work with files (it works with > named pipes of course, so it would have been a good idea to keep it): That's why we have a thread pool to do asynchronous IO to files. > Anyway, 3/3 is withdrawn since as far as libvirt is concerned I can > use migrate+cont. Do you have any comments on 1/3 and 2/3 to include > them as cleanups, or you prefer to go with just your small patch to > fix the unconditional restart after an error? I prefer the small fix. Regards, Anthony Liguori > Paolo