From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPFc1-0003Ea-Aq
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:54:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPFbo-0002vY-UU
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:53:53 -0400
Received: from [199.232.76.173] (port=36473 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPFbo-0002vC-Mx
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:53:48 -0400
Received: from mail-qy0-f174.google.com ([209.85.221.174]:38830)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MPFbo-0007az-1Q
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:53:48 -0400
Received: by qyk4 with SMTP id 4so650980qyk.4
	for <qemu-devel@nongnu.org>; Fri, 10 Jul 2009 05:53:47 -0700 (PDT)
Message-ID: <4A5739D8.60405@codemonkey.ws>
Date: Fri, 10 Jul 2009 07:53:44 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value
	instead of int.
References: <1246530731-14597-1-git-send-email-yamahata@valinux.co.jp>
	<1246530731-14597-7-git-send-email-yamahata@valinux.co.jp>
	<4A564003.5080707@codemonkey.ws>
	<20090710082121.GB5471@const.bordeaux.inria.fr>
In-Reply-To: <20090710082121.GB5471@const.bordeaux.inria.fr>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org

Samuel Thibault wrote:
> Anthony Liguori, le Thu 09 Jul 2009 14:07:47 -0500, a écrit :
>   
>> Isaku Yamahata wrote:
>>     
>>> use uint32_t for ioport port and value instead of int.
>>>  
>>>       
>> Why?
>>     
>
> In theory int could be only signed 16bit, so at least unsigned int could
> be needed for the port.

There's no platform that QEMU runs on that has a 16-bit integer and it's 
extraordinarily unlikely that there ever will be.

But the point is, patches need descriptive changelogs saying why there 
making a change, not just what the change is.

Regards,

Anthony Liguori