From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPFgn-00025O-Ip
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:58:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPFgj-00020R-UM
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:58:57 -0400
Received: from [199.232.76.173] (port=57872 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPFgj-000204-J0
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:58:53 -0400
Received: from mail-qy0-f174.google.com ([209.85.221.174]:47897)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MPFgi-0000eB-Us
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 08:58:53 -0400
Received: by qyk4 with SMTP id 4so652436qyk.4
	for <qemu-devel@nongnu.org>; Fri, 10 Jul 2009 05:58:50 -0700 (PDT)
Message-ID: <4A573B08.9010903@codemonkey.ws>
Date: Fri, 10 Jul 2009 07:58:48 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] build fix: xen on NetBSD/amd64
References: <200906301513.12043.Christoph.Egger@amd.com>
	<4A564322.5060502@codemonkey.ws>
	<200907101019.31977.Christoph.Egger@amd.com>
In-Reply-To: <200907101019.31977.Christoph.Egger@amd.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: qemu-devel@nongnu.org

Christoph Egger wrote:
> On Thursday 09 July 2009 21:21:06 Anthony Liguori wrote:
>   
>> Christoph Egger wrote:
>>     
>>> Hi!
>>>
>>> Attached patch fixes this build error on NetBSD/amd64:
>>>
>>> hw/xen_blkif.h:20: warning: #pragma pack(psuh[, id], <n>) is not
>>> supported on this target
>>> hw/xen_blkif.h:36: warning: #pragma pack(pop[, id], <n>) is not supported
>>> on this target
>>>
>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>>       
>> You'll invoke the fury of malc for introducing an identifier that begins
>> with '__' :-)
>>     
>
> In NetBSD, there is this in <sys/cdefs.h> :
>   

NetBSD is allowed to use these names in system headers but according to 
the C standard, normal programs like QEMU aren't.  So we need to use 
something other than __aligned.

Regards,

Anthony Liguori