From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPJqi-0000Ef-R2
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:25:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPJqe-00007S-CF
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:25:28 -0400
Received: from [199.232.76.173] (port=33189 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPJqd-000074-VH
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:25:24 -0400
Received: from mail-px0-f201.google.com ([209.85.216.201]:46075)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MPJqd-0005w4-Jj
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:25:23 -0400
Received: by pxi39 with SMTP id 39so647197pxi.4
	for <qemu-devel@nongnu.org>; Fri, 10 Jul 2009 10:25:22 -0700 (PDT)
Message-ID: <4A57797E.2010603@codemonkey.ws>
Date: Fri, 10 Jul 2009 12:25:18 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix default netmask to 255.255.255.0
References: <4A4CD24E.1090309@siemens.com> <4A577758.8010607@codemonkey.ws>
	<4A57786E.30200@siemens.com>
In-Reply-To: <4A57786E.30200@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

Jan Kiszka wrote:
> Anthony Liguori wrote:
>   
>> Jan Kiszka wrote:
>>     
>>> This got broken between a13a4126c8 and c92ef6a22d: old slirp code used
>>> 255.255.255.0.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>   
>>>       
>> I don't understand why, but this changeset breaks -net user for me.  I get:
>>
>> x86_64-softmmu/qemu-system-x86_64 -hda ~/images/linux.img -snapshot -L
>> ~/git/qemu/pc-bios
>> qemu: Could not initialize device 'user'
>>     
>
> Weird, double-checking locally. Is linux.img raw or something else (you
> know, that pending -snapshot breakage with raw image...)?
>   

It's a qcow2 and I don't know what -snapshot breakage you're referring to.

It's reproducible without -snapshot and reproducible directly on top of 
master (minus all the crap in staging).

Regards,

Anthony Liguori

> Jan
>
>