From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPK27-0006Ot-Rj for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:37:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPK23-0006Lc-1r for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:37:15 -0400 Received: from [199.232.76.173] (port=40536 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPK23-0006LZ-07 for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:37:11 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:17195) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MPK22-0007xr-Bl for qemu-devel@nongnu.org; Fri, 10 Jul 2009 13:37:10 -0400 Message-ID: <4A577C42.9090104@siemens.com> Date: Fri, 10 Jul 2009 19:37:06 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] slirp: Fix default netmask to 255.255.255.0 References: <4A4CD24E.1090309@siemens.com> <4A577758.8010607@codemonkey.ws> <4A57786E.30200@siemens.com> <4A57797E.2010603@codemonkey.ws> In-Reply-To: <4A57797E.2010603@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , qemu-devel , Avi Kivity Anthony Liguori wrote: > Jan Kiszka wrote: >> Anthony Liguori wrote: >> >>> Jan Kiszka wrote: >>> >>>> This got broken between a13a4126c8 and c92ef6a22d: old slirp code used >>>> 255.255.255.0. >>>> >>>> Signed-off-by: Jan Kiszka >>>> >>> I don't understand why, but this changeset breaks -net user for me. >>> I get: >>> >>> x86_64-softmmu/qemu-system-x86_64 -hda ~/images/linux.img -snapshot -L >>> ~/git/qemu/pc-bios >>> qemu: Could not initialize device 'user' >>> >> >> Weird, double-checking locally. Is linux.img raw or something else (you >> know, that pending -snapshot breakage with raw image...)? >> > > It's a qcow2 and I don't know what -snapshot breakage you're referring to. The one caused by Ram Pai's colon patch - but it was unrelated to this one. > > It's reproducible without -snapshot and reproducible directly on top of > master (minus all the crap in staging). Hmpf, my bad. Use this patch instead: ------> From: Jan Kiszka Subject: [PATCH] slirp: Fix default netmask to 255.255.255.0 This got broken between a13a4126c8 and c92ef6a22d: old slirp code used 255.255.255.0. Signed-off-by: Jan Kiszka --- net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net.c b/net.c index 1507f37..a0c4153 100644 --- a/net.c +++ b/net.c @@ -782,8 +782,8 @@ static int net_slirp_init(Monitor *mon, VLANState *vlan, const char *model, const char *vsmbserver) { /* default settings according to historic slirp */ - struct in_addr net = { .s_addr = htonl(0x0a000000) }; /* 10.0.0.0 */ - struct in_addr mask = { .s_addr = htonl(0xff000000) }; /* 255.0.0.0 */ + struct in_addr net = { .s_addr = htonl(0x0a000200) }; /* 10.0.2.0 */ + struct in_addr mask = { .s_addr = htonl(0xffffff00) }; /* 255.255.255.0 */ struct in_addr host = { .s_addr = htonl(0x0a000202) }; /* 10.0.2.2 */ struct in_addr dhcp = { .s_addr = htonl(0x0a00020f) }; /* 10.0.2.15 */ struct in_addr dns = { .s_addr = htonl(0x0a000203) }; /* 10.0.2.3 */