qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org, Andi Kleen <andi@firstfloor.org>,
	Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Huang Ying <ying.huang@intel.com>
Subject: Re: [Qemu-devel] [PATCH -v6] QEMU: MCE: Add MCE simulation to qemu/tcg
Date: Fri, 10 Jul 2009 13:43:41 -0500	[thread overview]
Message-ID: <4A578BDD.8010209@codemonkey.ws> (raw)
In-Reply-To: <20090710183019.GB8725@lst.de>

Christoph Hellwig wrote:
> On Tue, Jun 23, 2009 at 10:05:14AM +0800, Huang Ying wrote:
>   
>> - MCE features are initialized when VCPU is intialized according to CPUID.
>> - A monitor command "mce" is added to inject a MCE.
>> - A new interrupt mask: CPU_INTERRUPT_MCE is added to inject the MCE.
>>     
>
> This patch (now in the qemu tree) breaks compilation for me on i386:
>   

> /home/hch/work/qemu/target-i386/helper.c: In function
> 'cpu_inject_x86_mce':
> /home/hch/work/qemu/target-i386/helper.c:1510: error: left shift count >= width of type
>   

I pushed a fix to master.

Regards,

Anthony Liguori

      reply	other threads:[~2009-07-10 18:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-23  2:05 [Qemu-devel] [PATCH -v6] QEMU: MCE: Add MCE simulation to qemu/tcg Huang Ying
2009-06-30 18:12 ` [Qemu-devel] " Anthony Liguori
2009-07-01  1:14   ` Huang Ying
2009-07-07  1:58   ` Huang Ying
2009-07-09  1:43   ` Huang Ying
2009-07-10 18:30 ` [Qemu-devel] " Christoph Hellwig
2009-07-10 18:43   ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A578BDD.8010209@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=andi@firstfloor.org \
    --cc=avi@redhat.com \
    --cc=hch@lst.de \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).