From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPL4Y-0001D6-1C
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 14:43:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPL4T-0001C2-J0
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 14:43:49 -0400
Received: from [199.232.76.173] (port=54597 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPL4T-0001Bz-Em
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 14:43:45 -0400
Received: from mail-qy0-f174.google.com ([209.85.221.174]:39755)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MPL4S-0003Bm-TB
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 14:43:45 -0400
Received: by qyk4 with SMTP id 4so868614qyk.4
	for <qemu-devel@nongnu.org>; Fri, 10 Jul 2009 11:43:44 -0700 (PDT)
Message-ID: <4A578BDD.8010209@codemonkey.ws>
Date: Fri, 10 Jul 2009 13:43:41 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH -v6] QEMU: MCE: Add MCE simulation to qemu/tcg
References: <1245722714.22246.424.camel@yhuang-dev.sh.intel.com>
	<20090710183019.GB8725@lst.de>
In-Reply-To: <20090710183019.GB8725@lst.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org, Andi Kleen <andi@firstfloor.org>, Avi Kivity <avi@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Huang Ying <ying.huang@intel.com>

Christoph Hellwig wrote:
> On Tue, Jun 23, 2009 at 10:05:14AM +0800, Huang Ying wrote:
>   
>> - MCE features are initialized when VCPU is intialized according to CPUID.
>> - A monitor command "mce" is added to inject a MCE.
>> - A new interrupt mask: CPU_INTERRUPT_MCE is added to inject the MCE.
>>     
>
> This patch (now in the qemu tree) breaks compilation for me on i386:
>   

> /home/hch/work/qemu/target-i386/helper.c: In function
> 'cpu_inject_x86_mce':
> /home/hch/work/qemu/target-i386/helper.c:1510: error: left shift count >= width of type
>   

I pushed a fix to master.

Regards,

Anthony Liguori