From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPLPY-0008Ga-NB for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:05:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPLPT-0008CQ-7s for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:05:31 -0400 Received: from [199.232.76.173] (port=40794 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPLPT-0008CN-2e for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:05:27 -0400 Received: from mx2.redhat.com ([66.187.237.31]:60856) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MPLPS-0006kU-Hn for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:05:26 -0400 Message-ID: <4A579079.6020004@redhat.com> Date: Fri, 10 Jul 2009 21:03:21 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 10/13] qdev: add user-specified identifier to devices. References: <1247225179-5495-1-git-send-email-kraxel@redhat.com> <1247225179-5495-11-git-send-email-kraxel@redhat.com> <200907101831.28688.paul@codesourcery.com> In-Reply-To: <200907101831.28688.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On 07/10/09 19:31, Paul Brook wrote: > On Friday 10 July 2009, Gerd Hoffmann wrote: >> struct DeviceState { >> + char id[32]; > > Fixed size buffers are almost always wrong. Why 31 characters? 640k is enougth for everybody ;) I'll fix it up and make it dynamic. cheers, Gerd