From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPLtK-0003WF-Py
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:36:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPLtF-0003Ut-BQ
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:36:17 -0400
Received: from [199.232.76.173] (port=41104 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPLtF-0003Uq-4k
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:36:13 -0400
Received: from mail-qy0-f174.google.com ([209.85.221.174]:38919)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MPLtE-0003OX-R5
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:36:12 -0400
Received: by qyk4 with SMTP id 4so897774qyk.4
	for <qemu-devel@nongnu.org>; Fri, 10 Jul 2009 12:36:12 -0700 (PDT)
Message-ID: <4A579828.6010000@codemonkey.ws>
Date: Fri, 10 Jul 2009 14:36:08 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Sparc64 breakage by
	16eaedf2668e9b347a59d73346fcc4c764c58348
References: <f43fc5580907101210v7138d10awacdf006069283598@mail.gmail.com>
In-Reply-To: <f43fc5580907101210v7138d10awacdf006069283598@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>

Blue Swirl wrote:
> Hi,
>
> APB is not converted to qdev yet, so pci_register_secondary_bus
> shouldn't use FROM_QBUS. Sparc64 is currently broken.
>
> Partially reverting 16eaed... fixes the breakage:
> diff --git a/hw/pci.c b/hw/pci.c
> index 71d9227..f592925 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -135,7 +135,7 @@ static PCIBus
> *pci_register_secondary_bus(PCIDevice *dev, pci_map_irq_fn map_irq
>  {
>      PCIBus *bus;
>
> -    bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, &dev->qdev, NULL));
> +    bus = qemu_mallocz(sizeof(PCIBus));
>      bus->map_irq = map_irq;
>      bus->parent_dev = dev;
>      bus->next = dev->bus->next;
>   

Gerd, could you take a look?

Blue, you mentioned that you have an openbios-sparc64 image for 
testing?  Would that have uncovered this and if so, do you have a link 
handy?

Regards,

Anthony Liguori