From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPM6L-0004sk-RY
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:49:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPM6H-0004mO-5T
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:49:45 -0400
Received: from [199.232.76.173] (port=48072 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPM6G-0004mI-Tz
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:49:40 -0400
Received: from mx2.redhat.com ([66.187.237.31]:60280)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MPM6G-0007Ir-E1
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:49:40 -0400
Message-ID: <4A579AD3.1000903@redhat.com>
Date: Fri, 10 Jul 2009 21:47:31 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Sparc64 breakage by
	16eaedf2668e9b347a59d73346fcc4c764c58348
References: <f43fc5580907101210v7138d10awacdf006069283598@mail.gmail.com>
	<4A579828.6010000@codemonkey.ws>
In-Reply-To: <4A579828.6010000@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>

On 07/10/09 21:36, Anthony Liguori wrote:
> Blue Swirl wrote:
>> Hi,
>>
>> APB is not converted to qdev yet, so pci_register_secondary_bus
>> shouldn't use FROM_QBUS. Sparc64 is currently broken.

>> Partially reverting 16eaed... fixes the breakage:
>> --- a/hw/pci.c
>> +++ b/hw/pci.c
>> - bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, &dev->qdev, NULL));
>> + bus = qemu_mallocz(sizeof(PCIBus));

> Gerd, could you take a look?

As sparc64 is the only user of pci_register_secondary_bus() the partial 
reverse is fine IMHO.  Just let us defer this until APB is qdev-ified.

cheers,
   Gerd