From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPMjL-0005AA-Gi
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 16:30:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPMjG-00052Z-M0
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 16:30:02 -0400
Received: from [199.232.76.173] (port=52161 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPMjG-00052G-Hx
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 16:29:58 -0400
Received: from mx2.redhat.com ([66.187.237.31]:34153)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MPMjG-00062l-79
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 16:29:58 -0400
Message-ID: <4A57A449.5000907@redhat.com>
Date: Fri, 10 Jul 2009 22:27:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 04/13] qdev: add generic qdev_device_add()
References: <1247225179-5495-1-git-send-email-kraxel@redhat.com>
	<1247225179-5495-5-git-send-email-kraxel@redhat.com>
	<200907101823.07096.paul@codesourcery.com>
In-Reply-To: <200907101823.07096.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On 07/10/09 19:23, Paul Brook wrote:
> On Friday 10 July 2009, Gerd Hoffmann wrote:
>> Will be used for -device command line.
>
> I think this is going in the wrong direction. The device tree provides us with
> a standard way of identifying which bus to add a device to. We should be
> removing uses of pci_create, not adding new ones.

Why?

Let me guess: Because pci bus numbers are guest-changeable and thus not 
stable?

How about using user-specified ids to specify busses then?

PCI example:
   instead of  -device $name,addr=$bus:$slot.$fn
   use         -device $name,bus=root,addr=$slot.$fn

SCSI example:
   host adapter:  -device lsi,id=foo
   scsi disk:     -device scsi-disk,bus=foo,addr=$lun

cheers,
   Gerd