From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MQpYu-0003fe-PI
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:29:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MQpYq-0003d9-1Z
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:29:20 -0400
Received: from [199.232.76.173] (port=53186 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MQpYp-0003cw-RW
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:29:15 -0400
Received: from moutng.kundenserver.de ([212.227.17.9]:60750)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1MQpYo-0003Cz-M4
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 17:29:15 -0400
Message-ID: <4A5CF89D.2000103@mail.berlios.de>
Date: Tue, 14 Jul 2009 23:29:01 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Fix parsing of pattern arguments
References: <1247315696-5877-1-git-send-email-weil@mail.berlios.de>
	<1247315744-5911-1-git-send-email-weil@mail.berlios.de>
	<20090714212449.GB7580@lst.de>
In-Reply-To: <20090714212449.GB7580@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Christoph Hellwig schrieb:
> On Sat, Jul 11, 2009 at 02:35:44PM +0200, Stefan Weil wrote:
>   
>> atoi won't parse sedecimal pattern values (it always returns 0).
>> The qemu-iotests use such pattern values, to strtol is needed
>> to get correct results.
>>     
>
> Indeed.  But now that we're using strtol which can return useful
> errors I think we should also handle those errors.  Can you respin
> the patch with that error handling added?

Yes, but I'll finish the vdi driver first, so an improved patch will
have to wait a little.

I'd prefer to see the current version of the patch applied as
first step.

Regards,
Stefan