From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MR6a1-00052c-Ps for qemu-devel@nongnu.org; Wed, 15 Jul 2009 11:39:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MR6Zw-0004sN-TG for qemu-devel@nongnu.org; Wed, 15 Jul 2009 11:39:36 -0400 Received: from [199.232.76.173] (port=42406 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MR6Zw-0004s8-DN for qemu-devel@nongnu.org; Wed, 15 Jul 2009 11:39:32 -0400 Received: from mx2.redhat.com ([66.187.237.31]:43197) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MR6Zv-0002qt-U9 for qemu-devel@nongnu.org; Wed, 15 Jul 2009 11:39:32 -0400 Message-ID: <4A5DF7B4.4010806@redhat.com> Date: Wed, 15 Jul 2009 17:37:24 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Sparc32/PPC: convert escc to qdev References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel , Paul Brook , Juan Quintela On 07/15/09 16:47, Blue Swirl wrote: >> >> > + qdev_set_prop_int(dev, "frequency", clock); >>>> > + clock = qdev_get_prop_int(&dev->qdev, "clock", 0); > I see, thanks. Maybe an attempt to use an undeclared property should > raise an abort(). Once my qdev property monster patch is finally merged it all will be there. get_prop() is not needed any more, and set_prop works only for explicitly defined properties. cheers, Gerd