From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MR6zF-0007NX-2i for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:05:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MR6zA-0007Jn-TM for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:05:40 -0400 Received: from [199.232.76.173] (port=33360 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MR6zA-0007JR-L3 for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:05:36 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42515) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MR6z9-0007kk-EG for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:05:35 -0400 Message-ID: <4A5DFDCE.8000604@redhat.com> Date: Wed, 15 Jul 2009 18:03:26 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames References: <1245862739.6278.7.camel@localhost> <1245998284.6278.99.camel@localhost> <4A447C8D.5000104@kevin-wolf.de> <1246063310.6278.115.camel@localhost> <1246511321.6429.31.camel@localhost> <4A4C754D.10109@redhat.com> <4A4CAD86.9020607@us.ibm.com> <4A4CB39F.5070506@redhat.com> <1247041831.6297.12.camel@localhost> <1247644283.14246.3.camel@localhost> <4A5DF252.50408@us.ibm.com> In-Reply-To: <4A5DF252.50408@us.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , kvm-devel , linuxram@us.ibm.com, qemu-devel@nongnu.org, Blue Swirl , Jan Kiszka , Paul Brook On 07/15/09 17:14, Anthony Liguori wrote: > Blue Swirl wrote: >> I bet this won't compile on win32. >> >> Instead of this (IMHO doomed) escape approach, maybe the filename >> parameter could be specified as the next argument, for example: >> -hda format=qcow2,blah,blah,filename_is_next_arg -hda "filename with >> funky characters like ',' ':' & '!'" > > -drive name=hda,if=ide,cache=off -hda foo.img > -drive name=vda,if=virtio,cache=writeback -vda foo.img > -drive name=sdb,if=scsi,unit=1 -sdb boo.img > > But Paul has long objected to having -vda or -sda syntaxes. I do agree > though that the most sane thing to do is to make the filename an > independent argument. Jumping in here as I'm looking into this from the qdev-ifying point of view ;) I'd like to move to a model where -drive adds host-side state only and the actual disks are added via -device, i.e. something like -drive if=none,name=foo,file=/path/to/file -device virtio-blk-pci,drive=foo Instead of using '-drive if=none' we could use some other syntax where the filename can be passed as separate argument. Can switches have two arguments? If so, maybe this: -hostdrive $file $options comments? cheers, Gerd