From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MRR3y-0003HA-10
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 09:31:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MRR3t-0003Dj-85
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 09:31:53 -0400
Received: from [199.232.76.173] (port=37933 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MRR3t-0003Db-1a
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 09:31:49 -0400
Received: from mail-yx0-f188.google.com ([209.85.210.188]:34334)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MRR3s-00086w-Or
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 09:31:48 -0400
Received: by yxe26 with SMTP id 26so176302yxe.4
	for <qemu-devel@nongnu.org>; Thu, 16 Jul 2009 06:31:47 -0700 (PDT)
Message-ID: <4A5F2BC1.1040708@codemonkey.ws>
Date: Thu, 16 Jul 2009 08:31:45 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] 2nd try: [PATCH] fix for bad macaddr of e1000 in
	Windows 2003 server with original Microsoft driver
References: <4A5DC91F.7010009@redhat.com>
In-Reply-To: <4A5DC91F.7010009@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Naphtali Sprei <nsprei@redhat.com>
Cc: qemu-devel@nongnu.org

Naphtali Sprei wrote:
> After comments from quintela@trasno.org and mst@redhat.com, here's the 
> 2nd try:
>
>
> The sequence of reading from eeprom is "offset by one" moved because 
> of a false detection
> of a clock cycle after an eeprom reset. Keeping the last clock value 
> after a reset keeps it in sync.
>
> Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
> ---
> hw/e1000.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/e1000.c b/hw/e1000.c
> index 4ac8918..15598ab 100644
> --- a/hw/e1000.c
> +++ b/hw/e1000.c
> @@ -262,6 +262,8 @@ set_eecd(E1000State *s, int index, uint32_t val)
>     }
>     if (!(val & E1000_EECD_CS)) {              // rising, no CS 
> (EEPROM reset)
>         memset(&s->eecd_state, 0, sizeof s->eecd_state);
> +        // restore old_eecd's E1000_EECD_SK to avoid false detection 
> of a clock edge

Your mailer is wrapping these lines.  We also prefer C89 comments in QEMU.

Regards,

Anthony Liguori