From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRRUd-0006Vb-IX for qemu-devel@nongnu.org; Thu, 16 Jul 2009 09:59:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRRUY-0006VN-5r for qemu-devel@nongnu.org; Thu, 16 Jul 2009 09:59:26 -0400 Received: from [199.232.76.173] (port=39896 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRRUY-0006VK-09 for qemu-devel@nongnu.org; Thu, 16 Jul 2009 09:59:22 -0400 Received: from mx2.redhat.com ([66.187.237.31]:51180) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MRRUX-0004cb-Fu for qemu-devel@nongnu.org; Thu, 16 Jul 2009 09:59:21 -0400 Message-ID: <4A5F3234.8050703@redhat.com> Date: Thu, 16 Jul 2009 15:59:16 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1247734428-17757-1-git-send-email-kraxel@redhat.com> <1247734428-17757-3-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 2/3] add support for drive ids. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 07/16/09 15:53, Juan Quintela wrote: > Gerd Hoffmann wrote: >> -drive accepts the new id= now, allowing to explicitely name your >> drives. They will show up with that name in "info block" if specified, >> otherwise the existing namimg scheme is used to autogenerate one. >> >> There is also a new function to lookup drives by name. Not used yet. >> The plan is to link disk drivers and drives using the drive id instead >> of passing around pointers to BlockDriveState. > > Confusing. Stick with "id" or "name", but use the same everywhere? Yep, noticed myself while continuing hacking. I'll respin with a few more patches on top of that later today. cheers, Gerd