From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MRRfp-0008T0-AP
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 10:11:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MRRfj-0008Qy-Tq
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 10:10:59 -0400
Received: from [199.232.76.173] (port=60010 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MRRfj-0008Qi-7x
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 10:10:55 -0400
Received: from mail-qy0-f174.google.com ([209.85.221.174]:54550)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MRRfi-0006QU-Jq
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 10:10:54 -0400
Received: by qyk4 with SMTP id 4so112824qyk.4
	for <qemu-devel@nongnu.org>; Thu, 16 Jul 2009 07:10:54 -0700 (PDT)
Message-ID: <4A5F34EA.6020005@codemonkey.ws>
Date: Thu, 16 Jul 2009 09:10:50 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames
References: <1245862739.6278.7.camel@localhost>	<1246063310.6278.115.camel@localhost>	<1246511321.6429.31.camel@localhost>
	<4A4C754D.10109@redhat.com>	<4A4CAD86.9020607@us.ibm.com>
	<4A4CB39F.5070506@redhat.com>	<1247041831.6297.12.camel@localhost>	<1247644283.14246.3.camel@localhost>	<f43fc5580907150804l2d7efcb5k39f11dfa2f209f20@mail.gmail.com>	<4A5DF252.50408@us.ibm.com>	<f43fc5580907150829o4a07c57fge9fc402b872fb0bc@mail.gmail.com>	<4A5DF875.2020808@us.ibm.com>
	<87y6qoaglc.fsf@pike.pond.sub.org>
In-Reply-To: <87y6qoaglc.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, kvm-devel <kvm@vger.kernel.org>, linuxram@us.ibm.com, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, Paul Brook <paul@codesourcery.com>

Markus Armbruster wrote:
> Anthony Liguori <aliguori@us.ibm.com> writes:
>
>   
>> Blue Swirl wrote:
>>     
>>> Then how about something like:
>>>  -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img
>>>  -drive name=vda,if=virtio,cache=writeback,file_comes_next  -patharg  foo.img
>>>  -drive name=sdb,if=scsi,unit=1,fnarg -fnarg boo.img
>>>   
>>>       
>> The explicit ordering part seems clunky to me.  How about:
>>
>> -drive name=vda,if=virtio -drive.vda.file filename.img
>>
>> What's nice about this syntax is it generalizes well.  You could have:
>>
>> -drive.vda.if virtio -drive.vda.file filename.img
>> -net nic,model=rtl8139,name=foo -net.foo.macaddr 00:11:43:55:44:22
>>     
>
> Sanest proposal so far.  Just put filenames in separate arguments, as
> with almost every other program.
>
> Instead of name=, let's use id= from Gerd's qdev work.
>   

Works for me.

> Why "-drive.ID.NAME VALUE", "-net.ID.NAME VALUE" and so forth, i.e. one
> option per object with parameters?  Assuming the ID name space is flat,
> a single option suffices.  What about "-set ID.NAME=VALUE"?
>   

Looks attractive on the surface.  Feels really difficult to implement :-)

> Quoting is problematic.  Not only because it necessarily breaks some
> filenames that used to work, also because the shell quotes, too.  I
> don't enjoy counting backslashes.
>   

Yup.

Regards,

Anthony Liguori