From: Gerd Hoffmann <kraxel@redhat.com>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 1/3] kill drives_table
Date: Thu, 16 Jul 2009 16:54:32 +0200 [thread overview]
Message-ID: <4A5F3F28.3050804@redhat.com> (raw)
In-Reply-To: <m3d480hg02.fsf@neno.mitica>
On 07/16/09 16:14, Juan Quintela wrote:
> Gerd Hoffmann<kraxel@redhat.com> wrote:
>> diff --git a/qemu-char.c b/qemu-char.c
>> index 287e0cd..a7d8fb6 100644
>> --- a/qemu-char.c
>> +++ b/qemu-char.c
>> @@ -345,10 +345,12 @@ static int mux_proc_byte(CharDriverState *chr, MuxDriver *d, int ch)
>> }
>> case 's':
>> {
>> +#if 0
>> int i;
>> for (i = 0; i< nb_drives; i++) {
>> bdrv_commit(drives_table[i].bdrv);
>> }
>> +#endif
>> }
>> break;
>> case 'b':
>
> Why you didn't translate this one, you translate th erest of similar ones?
Not sure, probably just some leftover.
It certainly wasn't intended to make it into the final version of the
patch, will fix.
cheers,
Gerd
next prev parent reply other threads:[~2009-07-16 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 8:53 [Qemu-devel] [PATCH v2 0/3] cleanup drive handling Gerd Hoffmann
2009-07-16 8:53 ` [Qemu-devel] [PATCH v2 1/3] kill drives_table Gerd Hoffmann
[not found] ` <m3d480hg02.fsf@neno.mitica>
2009-07-16 14:54 ` Gerd Hoffmann [this message]
2009-07-16 8:53 ` [Qemu-devel] [PATCH v2 2/3] add support for drive ids Gerd Hoffmann
[not found] ` <m3ljmohgyk.fsf@neno.mitica>
2009-07-16 13:59 ` [Qemu-devel] " Gerd Hoffmann
2009-07-16 8:53 ` [Qemu-devel] [PATCH v2 3/3] kill drives_opt Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5F3F28.3050804@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@trasno.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).