From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRSM8-0000x7-Jo for qemu-devel@nongnu.org; Thu, 16 Jul 2009 10:54:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRSM3-0000qp-IF for qemu-devel@nongnu.org; Thu, 16 Jul 2009 10:54:43 -0400 Received: from [199.232.76.173] (port=59674 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRSM3-0000qZ-6d for qemu-devel@nongnu.org; Thu, 16 Jul 2009 10:54:39 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37429) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MRSM2-00069y-Ks for qemu-devel@nongnu.org; Thu, 16 Jul 2009 10:54:38 -0400 Message-ID: <4A5F3F28.3050804@redhat.com> Date: Thu, 16 Jul 2009 16:54:32 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1247734428-17757-1-git-send-email-kraxel@redhat.com> <1247734428-17757-2-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 1/3] kill drives_table List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 07/16/09 16:14, Juan Quintela wrote: > Gerd Hoffmann wrote: >> diff --git a/qemu-char.c b/qemu-char.c >> index 287e0cd..a7d8fb6 100644 >> --- a/qemu-char.c >> +++ b/qemu-char.c >> @@ -345,10 +345,12 @@ static int mux_proc_byte(CharDriverState *chr, MuxDriver *d, int ch) >> } >> case 's': >> { >> +#if 0 >> int i; >> for (i = 0; i< nb_drives; i++) { >> bdrv_commit(drives_table[i].bdrv); >> } >> +#endif >> } >> break; >> case 'b': > > Why you didn't translate this one, you translate th erest of similar ones? Not sure, probably just some leftover. It certainly wasn't intended to make it into the final version of the patch, will fix. cheers, Gerd