From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRWEo-0001E8-Qu for qemu-devel@nongnu.org; Thu, 16 Jul 2009 15:03:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRWEk-0001Bc-1c for qemu-devel@nongnu.org; Thu, 16 Jul 2009 15:03:26 -0400 Received: from [199.232.76.173] (port=48352 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRWEj-0001BW-Qu for qemu-devel@nongnu.org; Thu, 16 Jul 2009 15:03:21 -0400 Received: from rv-out-0708.google.com ([209.85.198.244]:14495) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MRWEj-0005iR-7D for qemu-devel@nongnu.org; Thu, 16 Jul 2009 15:03:21 -0400 Received: by rv-out-0708.google.com with SMTP id b17so60531rvf.22 for ; Thu, 16 Jul 2009 12:03:20 -0700 (PDT) Message-ID: <4A5F7975.8020207@codemonkey.ws> Date: Thu, 16 Jul 2009 14:03:17 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 5/5] switch -drive to QemuOpts. References: <1247756224-19219-1-git-send-email-kraxel@redhat.com> <1247756224-19219-6-git-send-email-kraxel@redhat.com> <4A5F5053.5000809@codemonkey.ws> <4A5F7789.8070500@redhat.com> In-Reply-To: <4A5F7789.8070500@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann wrote: > Quick fix (incremental) attached. > Oh, and a leftover debug line ... Great, wait a day or two and please resend the series. I've already gotten everything in staging for the 0.11 freeze. I'm looking at pushing a tag later today after testing finishes. One thing that bothers me is that there is a really high rate of change in the qdev stuff. These series touch a lot of code and therefore cause quite a lot of conflicts. That concerns me that the long term maintenance of stable-0.11 is going to be really painful. So I'm thinking of making an exception for some of the more intrusive qdev changes and to continue pulling some of them in post freeze. It would have to be handled on a case by case basis but I'm specifically thinking of things like the Property refactoring you just did. What do you think? > cheers, > Gerd > Regards, Anthony Liguori