From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRWh9-0000gc-9Z for qemu-devel@nongnu.org; Thu, 16 Jul 2009 15:32:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRWh4-0000g1-3t for qemu-devel@nongnu.org; Thu, 16 Jul 2009 15:32:42 -0400 Received: from [199.232.76.173] (port=58321 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRWh3-0000fy-VG for qemu-devel@nongnu.org; Thu, 16 Jul 2009 15:32:37 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48622) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MRWh3-0003Ay-F9 for qemu-devel@nongnu.org; Thu, 16 Jul 2009 15:32:37 -0400 Message-ID: <4A5F8050.1090308@redhat.com> Date: Thu, 16 Jul 2009 21:32:32 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 5/5] switch -drive to QemuOpts. References: <1247756224-19219-1-git-send-email-kraxel@redhat.com> <1247756224-19219-6-git-send-email-kraxel@redhat.com> <4A5F5053.5000809@codemonkey.ws> <4A5F7789.8070500@redhat.com> <4A5F7975.8020207@codemonkey.ws> In-Reply-To: <4A5F7975.8020207@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 07/16/09 21:03, Anthony Liguori wrote: > Gerd Hoffmann wrote: >> Quick fix (incremental) attached. >> Oh, and a leftover debug line ... > > Great, wait a day or two and please resend the series. I'll be offline tomorrow, weekend and monday next week, so I can have a closer look tuesday (merge bugfix, rebase, fixup whatever shows up). > One thing that bothers me is that there is a really high rate of change > in the qdev stuff. These series touch a lot of code and therefore cause > quite a lot of conflicts. That concerns me that the long term > maintenance of stable-0.11 is going to be really painful. The by far worst offender is the property refactoring, and that one has seen no fundamental changes since quite a while. Lots of little tweaks though, mostly due to conflicts and due to devices being converted to udev introducing build failures. btw: blueswirl converted more sparc stuff to qdev, thus adding more build failures with the property rework patch applied. http://git.et.redhat.com/?p=qemu-kraxel.git;a=shortlog;h=refs/heads/qdev.v13 has fixes (four topmost patches), you might want to cherry pick them if you find your tree not building. All other patches are not *that* intrusive. > So I'm thinking of making an exception for some of the more intrusive > qdev changes and to continue pulling some of them in post freeze. It > would have to be handled on a case by case basis but I'm specifically > thinking of things like the Property refactoring you just did. I see the property refactoring in your queue already. And, yes, having that in 0.11 will most likely simplify backports alot. cheers, Gerd