From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRYcO-0002Qf-0B for qemu-devel@nongnu.org; Thu, 16 Jul 2009 17:35:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRYcJ-0002OK-55 for qemu-devel@nongnu.org; Thu, 16 Jul 2009 17:35:55 -0400 Received: from [199.232.76.173] (port=59569 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRYcI-0002OB-T5 for qemu-devel@nongnu.org; Thu, 16 Jul 2009 17:35:51 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:35188) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MRYcI-0000lH-Hf for qemu-devel@nongnu.org; Thu, 16 Jul 2009 17:35:50 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n6GLRlev011175 for ; Thu, 16 Jul 2009 15:27:47 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6GLZn4W193772 for ; Thu, 16 Jul 2009 15:35:49 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6GLZmkH031793 for ; Thu, 16 Jul 2009 15:35:49 -0600 Message-ID: <4A5F9D32.9060700@us.ibm.com> Date: Thu, 16 Jul 2009 16:35:46 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1247779525-16943-1-git-send-email-glommer@redhat.com> In-Reply-To: <1247779525-16943-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2] introduce on_vcpu List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Jan Kiszka , qemu-devel@nongnu.org Glauber Costa wrote: > on_vcpu is a qemu-kvm function that will make sure that a specific > piece of code will run on a requested cpu. We don't need that because > we're restricted to -smp 1 right now, but those days are likely to end soon. > > So for the benefit of having qemu-kvm share more code with us, I'm > introducing our own version of on_vcpu(). Right now, we either run > a function on the current cpu, or abort the execution, because it would > mean something is seriously wrong. > > As an example code, I "ported" kvm_update_guest_debug to use it, > with some slight differences from qemu-kvm. > > This is probably 0.12 material > > Signed-off-by: Glauber Costa > CC: Jan Kiszka > --- > kvm-all.c | 37 +++++++++++++++++++++++++++++++------ > 1 files changed, 31 insertions(+), 6 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index 61194b8..0c881e8 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -39,6 +39,8 @@ > do { } while (0) > #endif > > +CPUState *current_env; > + > That shouldn't be there anymore... -- Regards, Anthony Liguori